Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): video attachment upload #1754

Merged
merged 3 commits into from
Oct 23, 2023
Merged

fix(core): video attachment upload #1754

merged 3 commits into from
Oct 23, 2023

Conversation

kanat
Copy link
Contributor

@kanat kanat commented Oct 19, 2023

Submit a pull request

The default connectTimeout and receiveTimeout were too small for Video uploads.
Now we use default values similar to Android SDK.

Resolves: zendesk-42260
Related thread is here.

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

@kanat kanat changed the base branch from master to develop October 19, 2023 16:35
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b13aa32) 58.30% compared to head (9c09ff8) 58.30%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1754   +/-   ##
========================================
  Coverage    58.30%   58.30%           
========================================
  Files          292      292           
  Lines        18010    18010           
========================================
  Hits         10500    10500           
  Misses        7510     7510           
Files Coverage Δ
.../lib/src/core/http/stream_http_client_options.dart 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanat kanat changed the title fix video attachment upload fix(core): video attachment upload Oct 19, 2023
esarbanis
esarbanis previously approved these changes Oct 20, 2023
Copy link
Contributor

@esarbanis esarbanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged once the failed check is fixed.

@esarbanis esarbanis merged commit 844df20 into develop Oct 23, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants