Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: z-index inside attachment preview #316

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

szuperaz
Copy link
Collaborator

@szuperaz szuperaz commented Oct 3, 2024

🎯 Goal

This PR affects both Angular and React (I tested with the React vite example app).

Issue: the delete and retry icons had higher z-index than the channel list menu, causing a visual glitch

Screenshot 2024-10-03 at 10 19 27

Copy link
Contributor

@myandrienko myandrienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there ever a case when something from the channel should overlay something from the channel list? If not, maybe we can make the whole channel its own stacking context with z-index below channel list?

I understand if that's too scary of a change, so this PR works for me too 🐸

@szuperaz
Copy link
Collaborator Author

szuperaz commented Oct 3, 2024

Is there ever a case when something from the channel should overlay something from the channel list? If not, maybe we can make the whole channel its own stacking context with z-index below channel list?

I understand if that's too scary of a change, so this PR works for me too 🐸

This issue can also cause problems inside the channel, because the icons could appear above the floating message menu (at least for Angular), so we still need this as well.

Still, your suggestion makes sense, but yes, it's scary.

@szuperaz szuperaz merged commit ad62885 into main Oct 3, 2024
1 check passed
@szuperaz szuperaz deleted the attachment-preview-z-index-fix branch October 3, 2024 16:04
github-actions bot pushed a commit that referenced this pull request Oct 3, 2024
## [5.1.1](v5.1.0...v5.1.1) (2024-10-03)

### Bug Fixes

* z-index inside attachment preview ([#316](#316)) ([ad62885](ad62885))
Copy link

github-actions bot commented Oct 3, 2024

🎉 This PR is included in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants