Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5148] Crash on MediaGalleryPreviewActivity #5387

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Aug 29, 2024

🎯 Goal

Potential fix for #5148

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat requested a review from a team as a code owner August 29, 2024 17:23
@kanat kanat added bug Something isn't working compose Jetpack Compose labels Aug 29, 2024
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kanat kanat enabled auto-merge (squash) August 30, 2024 13:38
@kanat kanat merged commit 70da8ba into develop Aug 30, 2024
7 checks passed
@kanat kanat deleted the bugfix/crash-media-preview branch August 30, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compose Jetpack Compose
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on MediaGalleryPreviewActivity: Missing messageId necessary to load images.
2 participants