Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4891] migration guide for ChannelsScreen #4892

Merged
merged 2 commits into from
Jul 25, 2023
Merged

[4891] migration guide for ChannelsScreen #4892

merged 2 commits into from
Jul 25, 2023

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Jul 24, 2023 •
edited
Loading

🎯 Goal

Closes: #4891

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat marked this pull request as ready for review July 24, 2023 22:55
@kanat kanat requested a review from a team as a code owner July 24, 2023 22:55
@kanat kanat requested review from JcMinarro and skydoves July 24, 2023 22:55
skydoves
skydoves approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@kanat kanat enabled auto-merge (squash) July 25, 2023 14:46
@kanat kanat merged commit 177206d into develop Jul 25, 2023
7 checks passed
@kanat kanat deleted the guides/channels-screen branch July 25, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

@JcMinarro JcMinarro Awaiting requested review from JcMinarro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanat @skydoves