Use resource id not dist in dashboard #4562
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janette
reviewed
Sep 22, 2025
| 'data' => [ | ||
| '#theme' => 'datastore_dashboard_resource_cell', | ||
| '#uuid' => $dist['distribution_uuid'], | ||
| '#uuid' => $dist['resource_id'], |
Member
There was a problem hiding this comment.
Does it matter that the data property is still uuid?
Member
Author
There was a problem hiding this comment.
Well - depends what "matters" means 😄 . I did change that too at first but it required changing a lot more files, templates etc. I don't feel strongly though, if you think we should change the element/variable name too I can redo.
Member
Author
|
Now less sure, seems like there are other workflows where it's more useful to get the distribution ID... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4561
QA steps
3a187a87dc6cd47c48b6b4c4785224b7drush dkan:dataset-info cedcd327-4e5d-43f9-8eb1-c11850fa7c55