Skip to content

Conversation

@swirtSJW
Copy link
Contributor

@swirtSJW swirtSJW commented Sep 12, 2025

Fixes #4554

Describe your changes

Moves the metastore_update_8011 to a deploy hook so that config changes do not get overwritten during drush deploy.

QA Steps

  • git checkout 4544-move-hook-update-to-deploy
  • ddev composer install
  • ddev drush deploy
  • validate in the output that the deploy hook ran.
  • ddev drush cex
  • validate that you see new settings for the dkan_json_form_widget

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@swirtSJW swirtSJW self-assigned this Sep 12, 2025
@swirtSJW swirtSJW requested review from dafeder and janette September 12, 2025 14:23
@swirtSJW swirtSJW force-pushed the 4544-move-hook-update-to-deploy branch 2 times, most recently from cfa1a57 to cb46c6d Compare September 12, 2025 14:43
@swirtSJW
Copy link
Contributor Author

image

@swirtSJW
Copy link
Contributor Author

Hmm the metastore deploy hook runs, but still does not change configuration
image

I'm investigating.

@swirtSJW swirtSJW marked this pull request as draft September 12, 2025 14:49
@swirtSJW swirtSJW force-pushed the 4544-move-hook-update-to-deploy branch from cb46c6d to 7bcdef1 Compare September 12, 2025 15:11
@swirtSJW
Copy link
Contributor Author

Ok I added some more output to the deploy hook and I see why there are no config changes to PDC. PDC has no config to update.
image

So I chased this herring which I still think is a real issue, but for PDC only it turned out to be a red herring.

@swirtSJW
Copy link
Contributor Author

It did run, just did not fall into the "if" clauses due to PDC issues and not the fault of this move.

@dafeder
Copy link
Member

dafeder commented Sep 15, 2025

Let's discuss later today if you're able @swirtSJW . To be honest I'm not very familiar with deploy hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.21.0 hook_update_N gets wiped out during drush deploy

3 participants