Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping tutorial, Ontop CI #3

Merged
merged 154 commits into from
Nov 15, 2024
Merged

Mapping tutorial, Ontop CI #3

merged 154 commits into from
Nov 15, 2024

Conversation

CFGrote
Copy link
Member

@CFGrote CFGrote commented Oct 10, 2024

This PR

  • adds instructions for adding ontop mappings based on the ome_core owl ontology.
  • additions to CI
    • java installation
    • ontop-cli installation
    • omero-py installation (through miniconda)
    • mapping omero ports to host on same port numbers (patching the docker files in .omero/)
    • launching docker in dev mode (.omero/docker dev start_up)
    • a script to insert data into the spun up omero
    • a properties file to run ontop against the test infra omero

Currently, the script to insert data fails with

source ci_utils/insert_data.sh
InternalException: Failed to connect: Ice.ConnectionLostException:
recv() returned zero
Error: Process completed with exit code 44.

This does not happen if run live on a PC. @joshmoore, do you have any clue what may be the cause?

@CFGrote CFGrote marked this pull request as draft October 10, 2024 20:06
@CFGrote CFGrote marked this pull request as ready for review October 10, 2024 20:30
CFGrote and others added 11 commits October 10, 2024 22:38
WIP: MapAnnotations and KV pairs.
- add section on mapping ome_core ontology.
- add screenshots
- mapping based on ome_core.owl
- screenshots
- construct for key-value annotations
- add link to norio's paper
- use org 'cause it rules ;)
CFGrote and others added 27 commits October 18, 2024 16:08
- Add two tags
- Tag one dataset and all images with tag 1 and tag 2, respectively.
- Add tests to check querying of tagged dataset and images.
- Add new property ome_core:tagAnnotationValue because ontop complained
about simultanous definition of tagAnnotation as ObjectProperty and
DataProperty. Use new property in mappings for tagged objects.
- add mappings for tagged images, datasets, and projects.
- Add more examples for tagged objects and aggregations.
- small fixes in tutorial
- add instructions to spin up the development environment to readme.
- add Experimenter mapping.
- Adding utility functions to run query and return results as dataframe.
- Add test for Image properties.
- add id as Image property.
- add disjoint properties for image, dataset, project.
- remove experimenterGroup property as it caused multiple type relations.
- Add roi class mapping
- add query for roi on images.
- test new mapping.

Note: Have to add ROIs to images 5,6 manually, see issue German-BioImaging#7.
- added two images with ROI
- adjust insert_data.sh: Adds these images to Dataset:2
- adjust test_queries.py: Test that two images (11, 12) have a ROI
@CFGrote CFGrote marked this pull request as ready for review November 15, 2024 09:20
@CFGrote CFGrote merged commit ebc2913 into German-BioImaging:main Nov 15, 2024
@joshmoore
Copy link
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants