Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new torrent states introduced in qBit5.0 #20

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

anriha
Copy link
Contributor

@anriha anriha commented Oct 6, 2024

Release of qBittorrent 5.0 renamed pausedUP and pausedDL to stoppedUP and stoppedDL. This just adds the states to the model, but not sure if this is the best way to handle this. If it were better to just remove them or leave them as is. Fortunately, from the limited part of this crate I use, this is the only breakage I experienced when updating.

Unfortunately https://github.com/qbittorrent/qBittorrent/wiki/WebUI-API-(qBittorrent-4.1) is still not updated to latest version so not sure how many other changes there were.

@George-Miao
Copy link
Owner

What about making an alias? We can keep the old names as the variant and make the new ones aliases. Maybe someday in future we can make a breaking change and correct the name one and for all.

@anriha
Copy link
Contributor Author

anriha commented Oct 8, 2024

Aah, missed that when reading serde docs. That is perfect. I force pushed new commit using this.

Copy link
Owner

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the PR!

@George-Miao George-Miao merged commit c80e6d6 into George-Miao:master Oct 8, 2024
1 of 4 checks passed
@George-Miao
Copy link
Owner

A new version has been released on crates.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants