feat(Status): warn before copying link to a private post (#1222)

GeopJr · Nov 28, 2024 · 68d272d · 68d272d
1 parent 44fa80f
commit 68d272d
Show file tree

Hide file tree

Showing 5 changed files with 44 additions and 2 deletions.
diff --git a/data/dev.geopjr.Tuba.gschema.xml b/data/dev.geopjr.Tuba.gschema.xml
@@ -85,6 +85,9 @@
 		<key name="reply-to-old-post-reminder" type="b">
 			<default>true</default>
 		</key>
+    <key name="copy-private-link-reminder" type="b">
+			<default>true</default>
+		</key>
 		<key name="spellchecker-enabled" type="b">
 			<default>true</default>
 		</key>

diff --git a/data/ui/dialogs/preferences.ui b/data/ui/dialogs/preferences.ui
@@ -164,6 +164,11 @@
 								<property name="title" translatable="yes">Warn before replying to an old post</property>
 							</object>
 						</child>
+						<child>
+							<object class="AdwSwitchRow" id="copy_private_link_reminder">
+								<property name="title" translatable="yes">Warn before copying a link to a private post</property>
+							</object>
+						</child>
 						<child>
 							<object class="AdwEntryRow" id="proxy_entry">
 								<property name="show-apply-button">0</property>

diff --git a/src/Dialogs/Preferences.vala b/src/Dialogs/Preferences.vala
@@ -129,6 +129,7 @@ public class Tuba.Dialogs.Preferences : Adw.PreferencesDialog {
 	[GtkChild] unowned Adw.SwitchRow advanced_boost_dialog;
 	[GtkChild] unowned Adw.SwitchRow darken_images_on_dark_mode;
 	[GtkChild] unowned Adw.SwitchRow reply_to_old_post_reminder;
+	[GtkChild] unowned Adw.SwitchRow copy_private_link_reminder;
 	[GtkChild] unowned Adw.EntryRow proxy_entry;
 	[GtkChild] unowned Adw.SwitchRow dim_trivial_notifications;
 
@@ -301,6 +302,7 @@ public class Tuba.Dialogs.Preferences : Adw.PreferencesDialog {
 		settings.bind ("advanced-boost-dialog", advanced_boost_dialog, "active", SettingsBindFlags.DEFAULT);
 		settings.bind ("darken-images-on-dark-mode", darken_images_on_dark_mode, "active", SettingsBindFlags.DEFAULT);
 		settings.bind ("reply-to-old-post-reminder", reply_to_old_post_reminder, "active", SettingsBindFlags.DEFAULT);
+		settings.bind ("copy-private-link-reminder", copy_private_link_reminder, "active", SettingsBindFlags.DEFAULT);
 		settings.bind ("dim-trivial-notifications", dim_trivial_notifications, "active", SettingsBindFlags.DEFAULT);
 		settings.bind ("analytics", analytics_switch, "active", SettingsBindFlags.DEFAULT);
 		settings.bind ("update-contributors", update_contributors, "active", SettingsBindFlags.DEFAULT);

diff --git a/src/Services/Settings.vala b/src/Services/Settings.vala
@@ -122,6 +122,7 @@ public class Tuba.Settings : GLib.Settings {
 	public bool group_push_notifications { get; set; }
 	public bool advanced_boost_dialog { get; set; }
 	public bool reply_to_old_post_reminder { get; set; }
+	public bool copy_private_link_reminder { get; set; }
 	public bool spellchecker_enabled { get; set; }
 	public bool darken_images_on_dark_mode { get; set; }
 	public double media_viewer_last_used_volume { get; set; }
@@ -154,6 +155,7 @@ public class Tuba.Settings : GLib.Settings {
 		"group-push-notifications",
 		"advanced-boost-dialog",
 		"reply-to-old-post-reminder",
+		"copy-private-link-reminder",
 		"spellchecker-enabled",
 		"darken-images-on-dark-mode",
 		"media-viewer-last-used-volume",

diff --git a/src/Widgets/Status.vala b/src/Widgets/Status.vala
@@ -369,8 +369,38 @@
 	}
 
 	private void copy_url () {
-		Host.copy (status.formal.url ?? status.formal.account.url);
-		app.toast (_("Copied post url to clipboard"));
+		if (status.formal.url != null && settings.copy_private_link_reminder && (status.formal.visibility == "direct" || status.formal.visibility == "private")) {
+			string body;
+			if (status.formal.visibility == "direct") {
+				body = _("Only mentioned people will be able to view it.");
+			} else if (status.formal.account.is_self ()) {
+				body = _("Only mentioned people and your followers will be able to view it.");
+			} else {
+				// translators: dialog subtitle shown when copying a link to a private post, the variable is a handle
+				body = _("Only mentioned people and people that follow %s will be able to view it.").printf (status.formal.account.full_handle);
+			}
+
+			app.question.begin (
+				// translators: the variable is the post visibility e.g. Public, Unlisted...
+				{_("This post's visibility is %s").printf (accounts.active.visibility[status.formal.visibility].name), false},
+				{ body, false },
+				app.main_window,
+				{ { _("Copy"), Adw.ResponseAppearance.SUGGESTED }, { _("Don't remind me again"), Adw.ResponseAppearance.DEFAULT } },
+				null,
+				false,
+				(obj, res) => {
+					if (app.question.end (res) == Tuba.Application.QuestionAnswer.NO) {
+						settings.copy_private_link_reminder = false;
+					}
+
+					Host.copy (status.formal.url);
+					app.toast (_("Copied post url to clipboard"));
+				}
+			);
+		} else {
+			Host.copy (status.formal.url ?? status.formal.account.url);
+			app.toast (_("Copied post url to clipboard"));
+		}
 	}
 
 	private void open_in_browser () {