Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXES #12766] API for timeseries settings #12767

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

[FIXES #12766] API for timeseries settings #12767

wants to merge 20 commits into from

Conversation

Gpetrak
Copy link
Contributor

@Gpetrak Gpetrak commented Dec 5, 2024

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

This PR introduces an API for time-series settings while it moves the GeoServer-API logic which is included to the geonode/layers/views and geonode/layers/api/views to the GeoServer helpers. The cooresponding issue is the #12766

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Dec 5, 2024
@Gpetrak Gpetrak marked this pull request as ready for review December 6, 2024 09:51
@Gpetrak Gpetrak requested a review from giohappy December 6, 2024 09:52
geonode/layers/api/serializers.py Outdated Show resolved Hide resolved
geonode/layers/models.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 31.90184% with 111 lines in your changes missing coverage. Please review.

Project coverage is 64.73%. Comparing base (91f32c6) to head (5fe9a57).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12767      +/-   ##
==========================================
- Coverage   67.00%   64.73%   -2.27%     
==========================================
  Files         952      953       +1     
  Lines       56912    57052     +140     
  Branches     6725     6736      +11     
==========================================
- Hits        38134    36934    -1200     
- Misses      17166    18537    +1371     
+ Partials     1612     1581      -31     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants