Don't quote GEOSERVER_JAVA_OPTS in .env #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quoted JAVA_OPTS causes issues in Docker Swarm deploys: the whole value is parsed and passed to Java as a single option.
giohappy
requested review from
mattiagiupponi and
etj
and removed request for
mattiagiupponi
|
From my tests this works fine also for Docker Compose. |
giohappy
approved these changes
Jan 9, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
Quoted JAVA_OPTS causes issues in Docker Swarm deploys: the whole value is parsed and passed to Java as a single option. Co-authored-by: Giovanni Allegri <[email protected]> (cherry picked from commit 7e919d6)
giohappy
pushed a commit
that referenced
this pull request
Jan 9, 2024
Quoted JAVA_OPTS causes issues in Docker Swarm deploys: the whole value is parsed and passed to Java as a single option. Co-authored-by: Giovanni Allegri <[email protected]> (cherry picked from commit 7e919d6) Co-authored-by: Francesco Camuffo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoted JAVA_OPTS causes issues in Docker Swarm deploys: the whole value is parsed and passed to Java as a single option.