Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove torch import, keep viewer open in render_on_macos.py #54

Closed
wants to merge 1 commit into from
Closed

Remove torch import, keep viewer open in render_on_macos.py #54

wants to merge 1 commit into from

Conversation

do-me
Copy link

@do-me do-me commented Dec 19, 2024

  • torch import is not needed
  • I guess most users would like to keep the viewer open to do something with the simulation. Maybe it's an idea to add an argument for this behavior where the default is to keep it open.

@do-me
Remove torch import, keep viewer open in render_on_macos.py
d8bd5a0 
- `torch` import is not needed
- I guess most users would like to keep the viewer open to do something with the simulation.
@zhouxian
Copy link
Collaborator

Thank you, but this seems not something that will enhance the capability <:(

@zhouxian zhouxian closed this Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@do-me @zhouxian