Skip to content

Commit

Permalink
rename error to DrawTimeoutLtMinimum
Browse files Browse the repository at this point in the history
  • Loading branch information
trmid committed Jun 28, 2024
1 parent ba4b59d commit ddf87b3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions src/PrizePool.sol
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,10 @@ error InvalidPrizeIndex(uint32 invalidPrizeIndex, uint32 prizeCount, uint8 tier)
/// @notice Thrown when there are no awarded draws when a computation requires an awarded draw.
error NoDrawsAwarded();

/// @notice Thrown when the prize pool is initialized with an invalid draw timeout.
/// @notice Thrown when the prize pool is initialized with a draw timeout lower than the minimum.
/// @param drawTimeout The draw timeout that was set
/// @param minimumDrawTimeout The minimum draw timeout
error InvalidDrawTimeout(uint24 drawTimeout, uint24 minimumDrawTimeout);
error DrawTimeoutLtMinimum(uint24 drawTimeout, uint24 minimumDrawTimeout);

/// @notice Thrown when the Prize Pool is constructed with a draw timeout greater than the grand prize period draws
error DrawTimeoutGTGrandPrizePeriodDraws();
Expand Down Expand Up @@ -345,7 +345,7 @@ contract PrizePool is TieredLiquidityDistributor {
)
{
if (params.drawTimeout < MINIMUM_DRAW_TIMEOUT) {
revert InvalidDrawTimeout(params.drawTimeout, MINIMUM_DRAW_TIMEOUT);
revert DrawTimeoutLtMinimum(params.drawTimeout, MINIMUM_DRAW_TIMEOUT);
}

if (params.drawTimeout > params.grandPrizePeriodDraws) {
Expand Down
8 changes: 4 additions & 4 deletions test/PrizePool.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
PrizeIsZero,
ConstructorParams,
InsufficientRewardsError,
InvalidDrawTimeout,
DrawTimeoutLtMinimum,
MINIMUM_DRAW_TIMEOUT,
DrawTimeoutGTGrandPrizePeriodDraws,
PrizePoolNotShutdown,
Expand Down Expand Up @@ -161,13 +161,13 @@ contract PrizePoolTest is Test {
assertEq(prizePool.drawPeriodSeconds(), drawPeriodSeconds);
}

function testInvalidDrawTimeout() public {
function testDrawTimeoutLtMinimum() public {
params.drawTimeout = 0;
vm.expectRevert(abi.encodeWithSelector(InvalidDrawTimeout.selector, 0, 2));
vm.expectRevert(abi.encodeWithSelector(DrawTimeoutLtMinimum.selector, 0, 2));
new PrizePool(params);

params.drawTimeout = 1;
vm.expectRevert(abi.encodeWithSelector(InvalidDrawTimeout.selector, 1, 2));
vm.expectRevert(abi.encodeWithSelector(DrawTimeoutLtMinimum.selector, 1, 2));
new PrizePool(params);

assertEq(MINIMUM_DRAW_TIMEOUT, 2); // validate assumptions
Expand Down

0 comments on commit ddf87b3

Please sign in to comment.