Fix: post-QA issues #57
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| loading: true, | ||
| error: 'There was a problem connecting to your Google account', | ||
| }); | ||
| setStep(Step.CONNECT_EOA); |
There was a problem hiding this comment.
I struggle to understand this part. You're checking if personalWalletId exists to check if the smart wallet creation was successful or not?
If it's false, why should we setStep(Step.CONNECT_EOA)? ConnectEOAModal modal is for forming the (realOpAddress, smartWalletAddress) mapping in our backend. Ideally, we would check if the mapping exists in the db or not, if it exists we move the user to the step === Step.SUCCESS if not, to the step === Step.CONNECT_EOA. However, since we are lacking that endpoint, I would move all users regardless to the step === Step.CONNECT_EOA.
However, I can't understand why we would move them to step === Step.CONNECT_EOA if !personalWalletId
There was a problem hiding this comment.
It's regarding this 1st point #4 (comment)
If the user already has a smart wallet but only logged out (token expired) we should not show the create wallet loading, connect, and success connection models, we have to close the modal automatically after the OTP is correct. #58](#58)
so that is just to not show the connect and success modals
There was a problem hiding this comment.
personalWalletId
is just to check if the user has already a smart wallet
Related to #4 (comment) & #5 (comment) & #30 (comment) & #37