Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X connect #162

Merged
merged 27 commits into from
Dec 5, 2024
Merged

X connect #162

merged 27 commits into from
Dec 5, 2024

Conversation

HrithikSampson
Copy link
Collaborator

relates to #161

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pairwise-rf6 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 6:02am

Copy link

vercel bot commented Nov 27, 2024

Deployment failed with the following error:

The `vercel.json` schema validation failed with the following message: `functions.app/api/verifyTwitter/route.js.includeFiles` should be string

Learn More: https://vercel.com/docs/concepts/projects/project-configuration

@HrithikSampson HrithikSampson changed the title WIP: X connect X connect Nov 27, 2024
@mmahdigh
Copy link
Collaborator

mmahdigh commented Dec 5, 2024

Great job!

@mmahdigh mmahdigh merged commit 793bcac into staging Dec 5, 2024
2 checks passed
@mmahdigh
Copy link
Collaborator

mmahdigh commented Dec 5, 2024

How do we control the case of someone using an already-used tweet from another person to connect to their X account?

We can probably do something with our backend for that. But how about an intruder who uses someone else's tweet before the original poster has been able to authenticate themselves?

@HrithikSampson

@HrithikSampson
Copy link
Collaborator Author

an probably do something with our backend for that. But how about an intruder who uses someone else's tweet before the original poster has been able to authenticate themselves?

I was thinking in the lines of being able to send a private dm but I cant think of anything yet, or limit the message to a group but the problem was shown in this post https://www.quora.com/How-do-I-send-a-private-tweet-to-one-person-only-that-no-one-else-can-see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants