cmake: Remove unused checks. #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of the header checks were used for that and can be removed. One was used to check for `sys/time.h` and then enable `gettimeofday()` so we can instead just check for the `gettimeofday()` function instead. Remove unused check for size of `int`. Remove unused check for `getpagesize()`. Remove `GECODE_HAS_UNISTD_H` from the config header as it isn't used or set by anything (any longer).
|
Many of these didn't mirror checks in |
|
@zayenz Checking in on this as if this can land, I have some other things that I'd like to submit so that I don't lose track of them. |
|
@waywardmonkeys Thanks for pinging me again. I started a new job this monday, so been a bit busy. AFAICS, this looks like a good cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the header checks were used for that and can be removed.
One was used to check for
sys/time.hand then enablegettimeofday()so we can instead just check for thegettimeofday()function instead.Remove unused check for size of
int.Remove unused check for
getpagesize().Remove
GECODE_HAS_UNISTD_Hfrom the config header as it isn't used or set by anything (any longer).