Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/6.3.0 #158

Merged
merged 10 commits into from
Nov 10, 2023
Merged

Release/6.3.0 #158

merged 10 commits into from
Nov 10, 2023

Conversation

fkonvick
Copy link

@fkonvick fkonvick commented Feb 8, 2023

This is the (hopefully complete) collection of my changes to Gecode for 6.3.0. I did not create a separate branch for each change but hopefully the changes are simple enough to review.

@ozgurakgun
Copy link

Hi @fkonvick - thanks for this.

I tried building this PR, but got an error (on macos, arm processor)

g++ -I. -I.. -Qunused-arguments -fno-rounding-math -ffinite-math-only -fno-math-errno -fno-strict-aliasing -O3 -fvisibility=hidden -ggdb -std=c++17 -pipe -Wno-unknown-pragmas -Wall -Wextra -fPIC -pthread -DNDEBUG   \
	 \
	-c -o gecode/flatzinc/flatzinc.o  ../gecode/flatzinc/flatzinc.cpp
g++ -I. -I.. -Qunused-arguments -fno-rounding-math -ffinite-math-only -fno-math-errno -fno-strict-aliasing -O3 -fvisibility=hidden -ggdb -std=c++17 -pipe -Wno-unknown-pragmas -Wall -Wextra -fPIC -pthread -DNDEBUG   \
	 \
	-c -o gecode/flatzinc/registry.o  ../gecode/flatzinc/registry.cpp
g++ -I. -I.. -Qunused-arguments -fno-rounding-math -ffinite-math-only -fno-math-errno -fno-strict-aliasing -O3 -fvisibility=hidden -ggdb -std=c++17 -pipe -Wno-unknown-pragmas -Wall -Wextra -fPIC -pthread -DNDEBUG   \
	 \
	-c -o gecode/flatzinc/branch.o  ../gecode/flatzinc/branch.cpp
cp ../gecode/flatzinc/parser.tab.cpp gecode/flatzinc/parser.tab.cpp
g++ -I. -I.. -Qunused-arguments -fno-rounding-math -ffinite-math-only -fno-math-errno -fno-strict-aliasing -O3 -fvisibility=hidden -ggdb -std=c++17 -pipe -Wno-unknown-pragmas -Wall -Wextra -fPIC -pthread -DNDEBUG   \
	 \
	-c -o gecode/flatzinc/parser.tab.o  gecode/flatzinc/parser.tab.cpp
gecode/flatzinc/parser.tab.cpp:526:10: fatal error: 'parser.tab.hpp' file not found
#include "parser.tab.hpp"
         ^~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [gecode/flatzinc/parser.tab.o] Error 1

I remember getting this error in the past but I am not sure what the fix was, sorry.

@fkonvick
Copy link
Author

Thanks for trying. I think that this might be unrelated to my changes - could you successfully build the 6.3.0 release branch as is, without the PR applied?
I would think that parser.tab.hpp is a product of some Flex/Bison build steps, so perhaps your build configuration is missing these, or Perl.

@ozgurakgun
Copy link

I think you are right.

@zayenz zayenz merged commit 2e1359e into Gecode:release/6.3.0 Nov 10, 2023
0 of 3 checks passed
@fkonvick
Copy link
Author

@zayenz Thanks. I got a notification saying "Gecode release/6.3.0" and I thought wow :) but then I realized it was just a merge. If there's anything I can do to help, please let me know!

@zayenz
Copy link
Member

zayenz commented Nov 11, 2023

Yep, the branch name merged was a bit conspicuous.

Trying to get everything squared up now, and will check in on your build during next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants