-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace print with borders function with panel and change color to red in output.py #136
base: main
Are you sure you want to change the base?
Conversation
… from white to red
Hello @suppo01 can you please furnish screenshots that show what this looks like at:
I think that the reviewers of this PR are going to need to see additional context about this feature before they agree to merge it because of the fact that it is visual in nature. |
Hello @suppo01 please note that the build is failing for this PR. Can you please investigate this issue and try to resolve it? None of the members of our team will agree to review and then ultimately approve this PR for merging until the build issues are resolved. |
@suppo01 please identify two student members of our team for review and one student technical leader for review and tag them as the reviewers for this PR. |
I just ran and tested this code on my Linux computer running Ubuntu 22.04.4 LTS. Steps:
I tested Good news! This update for the box that displays the results works in both a large and small terminal window for my Linux window! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code works on my Linux computer and displays correctly. Code looks well documented and understandable for future users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @suppo01 for this PR, I will review it a final time and likely merge it this week. Please note that I need to first address some PRs for another project before I can return to merging PRs for this project. Let me know if you have questions, okay? |
The version is now 0.7.1 as agreed in class to be released using Pallas's automatic release feature. |
Adding Panel for UI Use
Description
I added the implementation of panel to the output.py file to replace the old system, the print with border function. With this, I also deleted the old function as it was no longer being used by any function in output.py or beyond. I also made the color of the panel displaying the checks to be red instead of white if the checks are not 100% complete. This makes it easier to distinguish the information from all the surrounding white text.
Type of Change
Contributors
Reminder