Add BuildingCardFactory #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowmancc
reviewed
Feb 17, 2024
|
|
||
| public interface BuildingCardFactory { | ||
|
|
||
| public enum Type { |
There was a problem hiding this comment.
卡牌名稱應該不能當作 type，建築物的名稱不算是常數的概念，只是建築卡有一個 name 的屬性
| } | ||
| } | ||
|
|
||
| public enum Color { |
There was a problem hiding this comment.
BuildingCard 才會有 color ，enum 不會放在 factory 這邊
| @@ -83,22 +82,46 @@ public static class UserRequest { | |||
| private List<BuildingCard> getBuildingCards() { | |||
| List<BuildingCard> cards = new ArrayList<>(); | |||
| Stream.of( | |||
There was a problem hiding this comment.
我覺得應該把創建卡牌的邏輯開一個類別來負責處理，usecase 只要負責去使用就好
...ackend/spring/src/main/java/tw/waterballsa/gaas/citadels/spring/BuildingCardFactoryImpl.java
Outdated
Show resolved
Hide resolved
|
我有把類別圖放在 issue 那邊，可以討論一下 |
timt1028
reviewed
Feb 19, 2024
| @Data | ||
| @AllArgsConstructor | ||
| public class BuildingCard { | ||
| String name; |
There was a problem hiding this comment.
此BuildingCard 類別可能要封裝屬性只能Get ，因為建築卡應該是不會被改變的~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#137