Add LoongArch64 support #2529
Open
Add LoongArch64 support #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesuji
reviewed
Jan 22, 2025
xtexChooser
force-pushed
the
loong64
branch
4 times, most recently
from
9a94347 to
9500d33
Compare
xtexChooser
force-pushed
the
loong64
branch
2 times, most recently
from
4c9660a to
ec4a299
Compare
peace-maker
requested changes
Jan 22, 2025
There was a problem hiding this comment.
Very cool, thank you for the contribution!
To fully support shellcraft syscall generation the pushstr shellcode is required too. Please consider adding that too if you'd like.
$ shellcraft loong64.linux.execve "/bin/sh" 0 0
...
AttributeError: 'module' object has no attribute 'pushstr'
| @@ -113,6 +113,7 @@ jobs: | |||
| - name: Install Linux dependencies | |||
| run: | | |||
| sudo apt-get update | |||
| # binutils-loongarch64-linux-gnu is not in Ubuntu 22.04 | |||
There was a problem hiding this comment.
We can switch to only testing on Ubuntu 24.04 after #2519 is merged.
Signed-off-by: Bingwu Zhang <[email protected]>
|
pushstr and pushstr_array has been added (: |
peace-maker
reviewed
Jan 23, 2025
| @@ -3,7 +3,7 @@ | |||
| # Based on Ubuntu | |||
| ############################################################ | |||
|
|
|||
| FROM ubuntu:jammy | |||
| FROM ubuntu:noble | |||
There was a problem hiding this comment.
I'd expect building the Docker images to fail now due to removal of python2 packages in 24.04. That won't be an issue when we drop Python2 support ourselves in #2519
There was a problem hiding this comment.
Yeah. I am waiting for that PR to be merged (:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.