[RFC] Initial papercut fixes for mobile #2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| @media only screen and (max-device-width: 750px) { | ||
| /* Make header links visible */ | ||
| body > header > .row { | ||
| height: auto; | ||
| } | ||
|
|
||
| body > header > .row > .hide-on-print { | ||
| background-color: #AD6A91; | ||
| border-radius: 4px; | ||
| } | ||
|
|
||
| /* Add margin between main content hero boxes since they will be on top | ||
| * of one another */ | ||
| .hero > .col#first { | ||
| margin-bottom: 2em; | ||
| } | ||
|
|
||
| /* Add margin between download / doc buttons since they will be on top | ||
| * of one another */ | ||
| .hero > .col#second a.primary { | ||
| margin-bottom: 1em; | ||
| } | ||
|
|
||
| /* Anchor footer to bottom, decrease font size | ||
| * NB: padding-bottom and height will need to be adjusted in the future | ||
| * if more content is added to the footer! */ | ||
| html { | ||
| position: relative; | ||
| } | ||
|
|
||
| body, html { | ||
| min-height: 100%; | ||
| margin: 0; | ||
| } | ||
|
|
||
| body > #content { | ||
| padding-bottom: 5em; | ||
| margin-bottom: 0; | ||
| } | ||
|
|
||
| body > footer { | ||
| position: absolute; | ||
| bottom: 0; | ||
| height: 5em; | ||
| font-size: 10pt; | ||
| } | ||
|
There was a problem hiding this comment. Can we have a small amount of padding here? Not sure why, but it seems to have none - at least on Fennec. There was a problem hiding this comment. Totally agree on this. Checkout the demo page now and see if that's better (clearing cache if necessary). There was a problem hiding this comment. This seems to have broken on 320x480: |
||
|
|
||
| body > footer > .row { | ||
| flex-wrap: wrap; | ||
| } | ||
|
|
||
| /* Since footer will not be one line, restore left-aligned text */ | ||
| body > footer > .row > .col-6#right { | ||
| text-align: left; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 750px?
This seems to work okay on mobiles in both orientation, but on some tablets (Nook, Fire, iPad/iPad mini), it looks weird in portrait mode because the tablet is 768 screen pixels. Namely, the hero columns are close together (they need the margin-bottom at line 14).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 750px limit is arbitrary, it's just to detect if the device is mobile or not. Would bumping it to 800px solve the tablet problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
768px is probably good. That is the width of older laptops/netbooks and most tablets, which would all benefit from this layout.