Skip to content

🐛 fix(unxt): parsing multi-word dimension names #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nstarman merged 1 commit into from
Jan 14, 2026
Merged

🐛 fix(unxt): parsing multi-word dimension names #554

nstarman merged 1 commit into from
Jan 14, 2026

Conversation

@nstarman
Copy link
Contributor

@nstarman nstarman commented Jan 13, 2026

Manual backport a bugfix from #551

@nstarman nstarman added this to the v1.8.x milestone Jan 13, 2026
Copilot AI review requested due to automatic review settings January 13, 2026 23:00
@github-actions github-actions bot added the 🐛 Fix a bug Fix a bug. label Jan 13, 2026
@codecov
Copy link

codecov bot commented Jan 13, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (versions/v1.9.x@fa04a6f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/unxt/_src/dimensions.py 80.64% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@                Coverage Diff                 @@
##             versions/v1.9.x     #554   +/-   ##
==================================================
  Coverage                   ?   96.62%           
==================================================
  Files                      ?       44           
  Lines                      ?     2162           
  Branches                   ?       79           
==================================================
  Hits                       ?     2089           
  Misses                     ?       55           
  Partials                   ?       18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI reviewed Jan 13, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR backports a bug fix from #551 that enables parsing multi-word dimension names in mathematical expressions. The implementation adds preprocessing to convert parenthesized dimension names to temporary identifiers before AST parsing, then maps them back during evaluation.

Changes:

  • Added preprocessing function to handle parenthesized dimension names with spaces (e.g., "(amount of substance)")
  • Fixed bug preventing negative exponents in dimension expressions (e.g., "length**-1")
  • Expanded documentation with comprehensive examples covering various use cases

@nstarman nstarman force-pushed the versions/v1.9.x/fix-dim-parsing branch from c05569b to 4ef9a36 Compare January 13, 2026 23:54
@github-actions github-actions bot added the ✅ Add / update / pass tests Add, update, or pass tests. label Jan 13, 2026
@nstarman nstarman force-pushed the versions/v1.9.x/fix-dim-parsing branch from 4ef9a36 to 056ac80 Compare January 13, 2026 23:57
@nstarman nstarman requested a review from Copilot January 13, 2026 23:57
Copilot AI reviewed Jan 14, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@nstarman nstarman merged commit b033b84 into GalacticDynamics:versions/v1.9.x Jan 14, 2026
32 checks passed
@nstarman nstarman deleted the versions/v1.9.x/fix-dim-parsing branch January 14, 2026 00:04
@nstarman
Copy link
Contributor Author

nstarman commented Jan 14, 2026 •
edited
Loading

@meeseeksdev backport onto versions/v1.8.x

@nstarman
Copy link
Contributor Author

nstarman commented Jan 14, 2026

@meeseeksdev backport onto versions/v1.8.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 14, 2026

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

@nstarman nstarman mentioned this pull request Jan 14, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

✅ Add / update / pass tests Add, update, or pass tests. 🐛 Fix a bug Fix a bug.

Projects

None yet

Milestone

v1.8.x

Development

Successfully merging this pull request may close these issues.

1 participant

@nstarman