-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixed build_all.cmd error in other language environments #41
base: main
Are you sure you want to change the base?
Conversation
I have fixed alternatively non-UTF8 symbols in d349960 |
Thank you for your support. |
This reverts commit 4169ebc.
I have pulled the changes and rebuilt, but I get the following error. As expected, the compiler does not build using UTF-8 in environments with special system locales, so it is necessary to explicitly use UTF-8 using an environment variable. If the environment variable "CL=/utf-8" was set just before the build, no compile error occurred.
|
I have merged |
Please, retest updated master once more. And may be tell me what CL to set locally to get your initial env. |
In my initial environment, the system locale is Shift-JIS, and Shift-JIS is also used in cl. However, I don't know how to explicitly force cl to use Shift-JIS...
OK, I'll try it.
Sorry, I don't understand this very well, so I will do some research. |
Overview
Currently, when build_all.cmd is executed in another language environment (e.g. Japanese), a compile error may occur.
This PR is designed to solve that compile error.
Cause
The reason for the error is that Cyrillic characters cannot be used in other language environments that use non-Unicode.
The code page used by the compiler depends on the system locale by default, and most Japanese environments use
CP932
for code pages.This may be different in other countries.
Changes
The following modifications have been made to resolve these problems.
CL=/utf-8
to fix the codepage used by the compiler toUTF-8
ä
, which is notUTF-8
compatible, witha
I am not sure if the fix is appropriate, so please check and let me know.