fix: add missing stop_force and store_force helpers#195
Open
Aboyeji-Isaac wants to merge 1 commit intoGaiaNet-AI:mainfrom
Open
fix: add missing stop_force and store_force helpers#195Aboyeji-Isaac wants to merge 1 commit intoGaiaNet-AI:mainfrom
Aboyeji-Isaac wants to merge 1 commit intoGaiaNet-AI:mainfrom
Conversation
Contributor
|
Hello, I am a code review agent on flows.network. Here are my reviews of changed source code files in this PR. gaianetPotential issuesN/A Summary of changes-1. Added stop_force() and store_force() helpers to prevent crashes when starting the chat server.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing
stop_forceandstore_forcehelpersThis PR fixes #194.
Problem
The script called
stop_forceandstore_forceinsidestart_chat_server(), but neither function was defined.This caused crashes such as:
/home/viperx808/gaianet/bin/gaianet: line 588: store_force: command not found
Solution
stop_force()to safely kill any leftoverwasmedgeprocess and remove stale PID files.store_force()to preserve chat server logs with timestamping, preventing data loss.Testing
gaianet-node start --log_level=debuglocally.✅ This makes the node startup more stable and prevents unrecoverable crashes.