[Re-Factor Client Hints] (5) Remove (unlaunched) lang client hint (w…

…eb-platform-tests#30781) Now that we've cleaned up the array indexing that was blocking this, let's move forward with removing this unused client hint. This is a part of a series of CLs to re-factor the client hints code: (1) Label hints with legacy names (2) Fix the naming of (unlaunched) `lang` client hint (3) Consolidate client hint name lists (4) Migrate from array to map indexing for client hint names (5) Remove (unlaunched) `lang` client hint Bug: 1227043 Change-Id: I57404516cd1f39f738f0fbd7c202de7adf063d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3160286 Auto-Submit: Ari Chivukula <[email protected]> Commit-Queue: Matt Falkenhagen <[email protected]> Reviewed-by: Matt Falkenhagen <[email protected]> Reviewed-by: David Dorwin <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Reviewed-by: Dominick Ng <[email protected]> Cr-Commit-Position: refs/heads/main@{#921893} Co-authored-by: Ari Chivukula <[email protected]>
Gabisampaio · Nov 18, 2021 · 50ac417 · 50ac417
1 parent 3e5703a
commit 50ac417
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 6 deletions.
diff --git a/client-hints/accept-ch-cache-revalidation.https.html b/client-hints/accept-ch-cache-revalidation.https.html
@@ -23,7 +23,6 @@
     "rtt",
     "downlink",
     "ect",
-    "lang",
     "sec-ch-ua",
     "sec-ch-ua-arch",
     "sec-ch-ua-platform",

diff --git a/client-hints/http-equiv-accept-ch-merge.https.html b/client-hints/http-equiv-accept-ch-merge.https.html
@@ -1,7 +1,7 @@
 <html>
 <head>
 <meta http-equiv="Accept-CH" content="viewport-width, rtt">
-<meta http-equiv="Accept-CH" content="downlink, ect, lang, sec-ch-prefers-color-scheme">
+<meta http-equiv="Accept-CH" content="downlink, ect, sec-ch-prefers-color-scheme">
 <body>
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
@@ -19,7 +19,6 @@
     // Verify that the browser includes client hints in the headers.
     assert_true(r.headers.has("device-memory-received"), "device-memory-received");
     assert_true(r.headers.has("dpr-received"), "dpr-received");
-    assert_true(r.headers.has("lang-received"), "lang-received");
     assert_true(r.headers.has("viewport-width-received"), "viewport-width-received");
 
     assert_true(r.headers.has("rtt-received"), "rtt-received");

diff --git a/client-hints/resources/echo-client-hints-received.py b/client-hints/resources/echo-client-hints-received.py
@@ -22,8 +22,6 @@ def main(request, response):
         response.headers.set(b"downlink-received", request.headers.get(b"downlink"))
     if b"ect" in request.headers:
         response.headers.set(b"ect-received", request.headers.get(b"ect"))
-    if b"Lang" in request.headers:
-        response.headers.set(b"lang-received", request.headers.get(b"Lang"))
     if b"sec-ch-ua-mobile" in request.headers:
         response.headers.set(b"mobile-received", request.headers.get(b"sec-ch-ua-mobile"))
     if b"sec-ch-prefers-color-scheme" in request.headers:

diff --git a/client-hints/resources/stale-echo-client-hints.py b/client-hints/resources/stale-echo-client-hints.py
@@ -16,7 +16,6 @@ def main(request, response):
         b"rtt",
         b"downlink",
         b"ect",
-        b"lang",
         b"sec-ch-ua",
         b"sec-ch-ua-arch",
         b"sec-ch-ua-platform",