Skip to content

fix #18#20

Open
NChristel wants to merge 1 commit intoGabeJWJ:masterfrom
NChristel:fix_language_error
Open

fix #18#20
NChristel wants to merge 1 commit intoGabeJWJ:masterfrom
NChristel:fix_language_error

Conversation

@NChristel
Copy link

Set default language to English in settings if OS language is not in recognized languages. That way the game won't crash if it can't find a language, but still shows a "???" at the language selection such that one may choose whatever language fits them best.

@GabeJWJ
Copy link
Owner

GabeJWJ commented Nov 15, 2025

Hey sorry for the late response.

First of all, it is touching too many files. Specifically, it removes the fallbacks in the font file which is a big problem. Most of the other unnecessary changes are fallout from the font file's uuid changing, but also you should remove the "side_side.jpg" and its import file. I don't know why those keep showing back up. Should look into it.

More importantly, I think the fix should be when the default language is set on lines 37 or 38. It's a little tricky to find out if the locale code is in the supported list or not, so I understand that's more work. Really, the languages thing should probably be a dictionary. I must've had a reason for not doing that, but I don't recall what it was. That kind of wide-reaching change is probably something I should do.

Let me know if you specifically want to, otherwise I'll do it myself and close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants