Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labs 2,3,4,5 submission #5

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Labs 2,3,4,5 submission #5

wants to merge 33 commits into from

Conversation

Anurni
Copy link

@Anurni Anurni commented Feb 12, 2024

No description provided.

@RasmusBlanck
Copy link
Contributor

Good!

Just a small comment about the time slots, it seems that the following format works:
"8:15": {time: "08:15"},

@vladmaraev vladmaraev force-pushed the main branch 3 times, most recently from 389c1aa to f89ca27 Compare February 21, 2024 08:44
Added extra sound features (finger snap) with Audacity (tried to do it with Azure but didn't manage).
Really tried my best with this one. :)
Worked on this quite awhile, had some issues with nesting some of the elements (for instance I tried to apply the <prosody pitch="low" rate="medium"></prosody> to the whole text, but for some reason it didn't work and I had to add it to each utterance separately). For some reason I also didn't hear any difference in the volume when adjusting it (for example I wanted to adjust the volume of the word "dirt" with <prosody volume="+20dB"></prosody>). Also some issues with emphasizing words, would be great if we could go through these elements once again? :)
@Anurni Anurni changed the title Lab 2 submission Lab 2,3 submission Feb 21, 2024
@Anurni Anurni changed the title Lab 2,3 submission Labs 2,3,4 submission Feb 29, 2024
@Anurni Anurni changed the title Labs 2,3,4 submission Labs 2,3,4,5 submission Mar 7, 2024
@Anurni
Copy link
Author

Anurni commented Mar 7, 2024

Lab5 code works otherwise but for some reason when this guard evaluates to true:
{guard: ({event}) => checkIfMeetingIntent(event.nluValue.topIntent) === true && checkThreshold(event.nluValue.intents[0].confidenceScore) === false, actions: "setRepetitionBackToZero", target: "VerifyTheTopIntentIsMeetingSpeak"},
I get an error that says Uncaught (in promise) TypeError: Cannot read properties of null (reading 'reject') at MicAudioSource.ts:142:57
This is weird because the equivalent guard for the WhoIsX intent works just fine!

Also, I didn't quite understand this question: "Can you implement a similar threshold for natural language understanding? How can it be combined with the ASR threshold? Justify your choice (as a comment in your code) and provide a sketch implementation." since I thought we are specifically supposed to inspect the confidence levels of the NLU model's intents.

@Anurni
Copy link
Author

Anurni commented Mar 11, 2024

lab 3 resource key: c6cfcc58f07142859860c92e1945fb8f

@Anurni
Copy link
Author

Anurni commented Mar 11, 2024

const azureLanguageCredentials = {
endpoint: "https://annis-lab4.cognitiveservices.azure.com/language/:analyze-conversations?api-version=2022-10-01-preview",
key: "5e24c0929d2944548c22a99ab629000c",
deploymentName: "appointment",
projectName: "appointment",
};

@RasmusBlanck
Copy link
Contributor

Lab 4 comments:

Well done!

The NLU for booking a meeting seems to be working very well. The interaction was generally smooth.

The machine seems to crash if asked for a celebrity for which there is no entity on the NLU side. I worked around this by looking at the json, but it would be good to have a failsafe in place.

Suggestions for improvement: Make it possible to say, for example, "Book a meeting with Vlad" directly, and get to the "at what day and time"-question. Your NLU training data suggests that this should be possible. Also, if the user only says a day in response to the "what day and time"-question, it would be good to get another question about the desired time. You can never trust your user. ;-)

@RasmusBlanck
Copy link
Contributor

Lab 5 comments:

Mostly good work, but there are two minor issues that I'd like you to fix:

In case you try to assign an out-of-grammar name to a meeting, the machine replies "I couldn't properly register the meeting title, sorry." and then just stops. I'm not sure exactly why it's doing that, and it feels like uninteded behaviour. (It's not really transparent exactly what kinds of meeting titles are available. In a "real" system, it would perhaps be more flexible if the meeting titles weren't constrained by a grammar. You don't have to change this, it's more of a general comment.)

If I say "Can I meet someone?" the machine just stops. There are two states named "VerifyTheTopIntentIsMeetingSpeak", which is probably the cause of this problem.

It should probably be pretty easy to fix this to get a pass.

@Anurni
Copy link
Author

Anurni commented Mar 29, 2024

If I say "Can I meet someone?" the machine just stops. There are two states named "VerifyTheTopIntentIsMeetingSpeak", which is probably the cause of this problem.

I fixed this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants