Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab 2,3,4,5 submission #4

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Conversation

alex-berman
Copy link

No description provided.

@alex-berman alex-berman changed the title Lab 2 submission Lab 2,3 submission Feb 20, 2024
@RasmusBlanck
Copy link
Contributor

Comments on lab 2 submission:

Good job. If you go through all the steps to create a meeting, but answer "no" to the final question confirming the details, then something strange happens:

Do you want me to create a meeting with ... on ... -> No -> Will it take the whole day? -> No -> Will it take the whole day? -> ...

My best guess is that that the slots for person and day have already been filled, so the system fast-tracks past these and tries to get a new time only.

@vladmaraev vladmaraev force-pushed the main branch 4 times, most recently from f89ca27 to 96cbfe4 Compare February 23, 2024 09:09
@alex-berman alex-berman changed the title Lab 2,3 submission Lab 2,3,4 submission Feb 29, 2024
@alex-berman alex-berman changed the title Lab 2,3,4 submission Lab 2,3,4,5 submission Mar 5, 2024
@RasmusBlanck
Copy link
Contributor

Lab5 comments:

OK.

The confidence thresholds as you've implemented them seem to be working pretty well, but the NLU threshold is of course more interesting when you use a trained NLU model.

The hard-coded slot filler "alex on monday" leads to a weird interaction, with the system asking "Will it take the whole day?" while it is in reality listening for a time. Regardless of whether I answer "yes" or "no" it lets me know that it didn't understand and asks me to repeat the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants