Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labs 2,3,4,5, lab5 fix submission #10

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ajejohansson
Copy link

No description provided.

@nastaiza14
Copy link
Collaborator

Good!

@vladmaraev vladmaraev force-pushed the main branch 3 times, most recently from 389c1aa to f89ca27 Compare February 21, 2024 08:44
@ajejohansson ajejohansson changed the title Lab 2 submission Labs 2,3 submission Feb 22, 2024
@ajejohansson
Copy link
Author

I think this request now has both labs 2 and 3. Let me know if that's not the case!

@ajejohansson ajejohansson changed the title Labs 2,3 submission Labs 2,3,4 submission Feb 29, 2024
@ajejohansson ajejohansson changed the title Labs 2,3,4 submission Labs 2,3,4,5 submission Mar 8, 2024
@nastaiza14
Copy link
Collaborator

I'm checking lab 5 and it is good, but there are just a couple fixes to make, which I think you yourself have pointed out in your comments:

  • if at any point I try to say something that is not picked up as an entity (in the "entities" array) the machine throws an error, even in cases where I say "Yeah, sure" in confirmation, for example. There is a rather simple way to fix this, though, and that is checking if there are any entities detected at all (you could check the array length as the very first thing in your list of guards, because as you have it now, it doesn't know what to do if one of the conditions (like the length) fails).

  • if we get to the "I don't seem to understand" state or the state where we ask for help, the machine goes to idle instead of going back, which is odd because the "no input" state works just fine, going back to the previous question.

Send me a message if you need help with any of this and we can take a look!

@ajejohansson
Copy link
Author

Hello,
Sorry about the very late response to this.
I have finally submitted the final project (on canvas to a different github repository), and will make sure the lab pull request is updated tomorrow.
Best,

@ajejohansson ajejohansson changed the title Labs 2,3,4,5 submission Labs 2,3,4,5, lab5 fix submission Apr 3, 2024
@ajejohansson
Copy link
Author

Hello,
Sorry again about the delay. I have fixed the issues noted on github. See updated dm5 file for updated code and comments. The problem with the utility states was very unintuitive, but I think it's fixed.
Best,

@nastaiza14
Copy link
Collaborator

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants