[Maintenance][Behat] Enable not creating a driver session in api scen…

…arios
GSadee · Dec 6, 2024 · 29781a3 · 29781a3
1 parent e28d800
commit 29781a3
Show file tree

Hide file tree

Showing 37 changed files with 44 additions and 4 deletions.
diff --git a/behat.yml.dist b/behat.yml.dist
@@ -58,6 +58,8 @@ default:
 
         SyliusLabs\SuiteTagsExtension: ~
 
+        Sylius\Bundle\ApiBundle\Behat\Extension\SyliusApiBundleExtension: ~
+
     gherkin:
         filters:
             tags: "~@todo&&~@cli" # CLI is excluded as it registers an error handler that mutes fatal errors
diff --git a/src/Sylius/Behat/Resources/config/suites/api/account/address_book.yml b/src/Sylius/Behat/Resources/config/suites/api/account/address_book.yml
@@ -36,3 +36,4 @@ default:
 
             filters:
                 tags: "@address_book&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/account/customer.yml b/src/Sylius/Behat/Resources/config/suites/api/account/customer.yml
@@ -46,3 +46,4 @@ default:
 
             filters:
                 tags: "@customer_account&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/account/customer_registration.yml b/src/Sylius/Behat/Resources/config/suites/api/account/customer_registration.yml
@@ -24,3 +24,4 @@ default:
 
             filters:
                 tags: "@customer_registration&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/account/email_verification.yml b/src/Sylius/Behat/Resources/config/suites/api/account/email_verification.yml
@@ -22,3 +22,4 @@ default:
 
             filters:
                 tags: "@email_verification&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/admin/dashboard.yaml b/src/Sylius/Behat/Resources/config/suites/api/admin/dashboard.yaml
@@ -7,7 +7,7 @@ default:
             contexts:
                 - sylius.behat.context.hook.doctrine_orm
                 - Sylius\Calendar\Tests\Behat\Context\Hook\CalendarContext
-                    
+
                 - sylius.behat.context.transform.admin
                 - sylius.behat.context.transform.shared_storage
                 - sylius.behat.context.transform.user
@@ -37,3 +37,4 @@ default:
 
             filters:
                 tags: "@admin_dashboard&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/cart/accessing_cart.yml b/src/Sylius/Behat/Resources/config/suites/api/cart/accessing_cart.yml
@@ -31,3 +31,4 @@ default:
 
             filters:
                 tags: "@accessing_cart&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/cart/shopping_cart.yml b/src/Sylius/Behat/Resources/config/suites/api/cart/shopping_cart.yml
@@ -31,3 +31,4 @@ default:
 
             filters:
                 tags: "@shopping_cart&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/channel/channels.yml b/src/Sylius/Behat/Resources/config/suites/api/channel/channels.yml
@@ -17,3 +17,4 @@ default:
 
             filters:
                 tags: "@channels&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/checkout/checkout.yml b/src/Sylius/Behat/Resources/config/suites/api/checkout/checkout.yml
@@ -59,3 +59,4 @@ default:
 
             filters:
                 tags: "@checkout&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/checkout/paying_for_order.yml b/src/Sylius/Behat/Resources/config/suites/api/checkout/paying_for_order.yml
@@ -44,3 +44,4 @@ default:
 
             filters:
                 tags: "@paying_for_order&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/contact/requesting_contact.yml b/src/Sylius/Behat/Resources/config/suites/api/contact/requesting_contact.yml
@@ -19,3 +19,4 @@ default:
 
             filters:
                 tags: "@requesting_contact&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/currency/currencies.yml b/src/Sylius/Behat/Resources/config/suites/api/currency/currencies.yml
@@ -20,3 +20,4 @@ default:
 
             filters:
                 tags: "@currencies&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/currency/viewing_exchange_rates.yml b/src/Sylius/Behat/Resources/config/suites/api/currency/viewing_exchange_rates.yml
@@ -22,3 +22,4 @@ default:
 
             filters:
                 tags: "@viewing_exchange_rates&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/homepage/viewing_products.yml b/src/Sylius/Behat/Resources/config/suites/api/homepage/viewing_products.yml
@@ -20,3 +20,4 @@ default:
 
             filters:
                 tags: "@homepage&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/inventory/cart_inventory.yml b/src/Sylius/Behat/Resources/config/suites/api/inventory/cart_inventory.yml
@@ -21,3 +21,4 @@ default:
 
             filters:
                 tags: "@cart_inventory&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/inventory/checkout_inventory.yaml b/src/Sylius/Behat/Resources/config/suites/api/inventory/checkout_inventory.yaml
@@ -32,3 +32,4 @@ default:
 
             filters:
                 tags: "@checkout_inventory&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/inventory/managing_inventory.yaml b/src/Sylius/Behat/Resources/config/suites/api/inventory/managing_inventory.yaml
@@ -33,3 +33,4 @@ default:
 
             filters:
                 tags: "@managing_inventory&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/locale/locales.yaml b/src/Sylius/Behat/Resources/config/suites/api/locale/locales.yaml
@@ -20,6 +20,7 @@ default:
                 - sylius.behat.context.api.shop.channel
                 - sylius.behat.context.api.shop.locale
                 - sylius.behat.context.api.shop.product
-                
+
             filters:
                 tags: "@locales&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/order/modifying_placed_order_address.yaml b/src/Sylius/Behat/Resources/config/suites/api/order/modifying_placed_order_address.yaml
@@ -42,3 +42,4 @@ default:
 
             filters:
                 tags: "@modifying_placed_order_address&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/order/order_history.yaml b/src/Sylius/Behat/Resources/config/suites/api/order/order_history.yaml
@@ -35,3 +35,4 @@ default:
 
             filters:
                 tags: "@order_history&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/payment/managing_payment_methods.yaml b/src/Sylius/Behat/Resources/config/suites/api/payment/managing_payment_methods.yaml
@@ -26,11 +26,12 @@ default:
                 - sylius.behat.context.transform.product
                 - sylius.behat.context.transform.shipping_method
                 - sylius.behat.context.transform.shared_storage
-                    
+
                 - sylius.behat.context.api.admin.save
                 - sylius.behat.context.api.admin.response
                 - Sylius\Behat\Context\Api\Admin\ManagingPaymentMethodsContext
                 - sylius.behat.context.api.admin.translation
 
             filters:
                 tags: "@managing_payment_methods&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/product/adding_product_review.yml b/src/Sylius/Behat/Resources/config/suites/api/product/adding_product_review.yml
@@ -25,3 +25,4 @@ default:
 
             filters:
                 tags: "@adding_product_review&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/product/viewing_product_reviews.yml b/src/Sylius/Behat/Resources/config/suites/api/product/viewing_product_reviews.yml
@@ -23,3 +23,4 @@ default:
 
             filters:
                 tags: "@viewing_product_reviews&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/promotion/applying_catalog_promotions.yml b/src/Sylius/Behat/Resources/config/suites/api/promotion/applying_catalog_promotions.yml
@@ -35,3 +35,4 @@ default:
 
             filters:
                 tags: "@applying_catalog_promotions&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/promotion/applying_promotion_coupon.yml b/src/Sylius/Behat/Resources/config/suites/api/promotion/applying_promotion_coupon.yml
@@ -37,3 +37,4 @@ default:
 
             filters:
                 tags: "@applying_promotion_coupon&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/promotion/applying_promotion_rules.yml b/src/Sylius/Behat/Resources/config/suites/api/promotion/applying_promotion_rules.yml
@@ -38,3 +38,4 @@ default:
                 - sylius.behat.context.api.shop.checkout
             filters:
                 tags: "@applying_promotion_rules&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/promotion/managing_catalog_promotions.yml b/src/Sylius/Behat/Resources/config/suites/api/promotion/managing_catalog_promotions.yml
@@ -33,3 +33,4 @@ default:
 
             filters:
                 tags: "@managing_catalog_promotions&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/promotion/managing_promotions.yml b/src/Sylius/Behat/Resources/config/suites/api/promotion/managing_promotions.yml
@@ -42,3 +42,4 @@ default:
 
             filters:
                 tags: "@managing_promotions&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/promotion/receiving_discount.yml b/src/Sylius/Behat/Resources/config/suites/api/promotion/receiving_discount.yml
@@ -38,3 +38,4 @@ default:
 
             filters:
                 tags: "@receiving_discount&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/promotion/removing_catalog_promotions.yml b/src/Sylius/Behat/Resources/config/suites/api/promotion/removing_catalog_promotions.yml
@@ -30,3 +30,4 @@ default:
 
             filters:
                 tags: "@removing_catalog_promotions&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/shipping/applying_shipping_method_rules.yml b/src/Sylius/Behat/Resources/config/suites/api/shipping/applying_shipping_method_rules.yml
@@ -37,3 +37,4 @@ default:
 
             filters:
                 tags: "@applying_shipping_method_rules&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/shipping/viewing_shipping_methods.yml b/src/Sylius/Behat/Resources/config/suites/api/shipping/viewing_shipping_methods.yml
@@ -36,3 +36,4 @@ default:
 
             filters:
                 tags: "@viewing_shipping_methods&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/taxation/applying_taxes.yml b/src/Sylius/Behat/Resources/config/suites/api/taxation/applying_taxes.yml
@@ -39,3 +39,4 @@ default:
 
             filters:
                 tags: "@applying_taxes&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/taxation/managing_tax_rates.yml b/src/Sylius/Behat/Resources/config/suites/api/taxation/managing_tax_rates.yml
@@ -23,3 +23,4 @@ default:
 
             filters:
                 tags: "@managing_tax_rates&&@api"
+            javascript: false
diff --git a/src/Sylius/Behat/Resources/config/suites/api/user/managing_users.yml b/src/Sylius/Behat/Resources/config/suites/api/user/managing_users.yml
@@ -23,3 +23,4 @@ default:
 
             filters:
                 tags: "@managing_users&&@api"
+            javascript: false
diff --git a/src/Sylius/Bundle/ApiBundle/Behat/Tester/ApiScenarioEventDispatchingScenarioTester.php b/src/Sylius/Bundle/ApiBundle/Behat/Tester/ApiScenarioEventDispatchingScenarioTester.php
@@ -40,7 +40,10 @@ public function setUp(Environment $env, FeatureNode $feature, Scenario $scenario
         }
 
         $tags = $scenario->getTags();
-        if (($key = array_search('javascript', $tags)) !== false) {
+        if (
+            ($key = array_search('javascript', $tags)) !== false ||
+            ($key = array_search('mink:chromedriver', $tags)) !== false
+        ) {
             unset($tags[$key]);
         }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -36,3 +36,4 @@ default:

		filters:
		tags: "@address_book&&@api"
		javascript: false
Original file line number	Diff line number	Diff line change
Expand Up		@@ -46,3 +46,4 @@ default:

		filters:
		tags: "@customer_account&&@api"
		javascript: false
Original file line number	Diff line number	Diff line change
Expand Up		@@ -24,3 +24,4 @@ default:

		filters:
		tags: "@customer_registration&&@api"
		javascript: false
Original file line number	Diff line number	Diff line change
Expand Up		@@ -22,3 +22,4 @@ default:

		filters:
		tags: "@email_verification&&@api"
		javascript: false
Original file line number	Diff line number	Diff line change
Expand Up		@@ -31,3 +31,4 @@ default:

		filters:
		tags: "@accessing_cart&&@api"
		javascript: false
Original file line number	Diff line number	Diff line change
Expand Up		@@ -17,3 +17,4 @@ default:

		filters:
		tags: "@channels&&@api"
		javascript: false
Original file line number	Diff line number	Diff line change
Expand Up		@@ -59,3 +59,4 @@ default:

		filters:
		tags: "@checkout&&@api"
		javascript: false
Original file line number	Diff line number	Diff line change
Expand Up		@@ -44,3 +44,4 @@ default:

		filters:
		tags: "@paying_for_order&&@api"
		javascript: false
Original file line number	Diff line number	Diff line change
Expand Up		@@ -19,3 +19,4 @@ default:

		filters:
		tags: "@requesting_contact&&@api"
		javascript: false
Original file line number	Diff line number	Diff line change
Expand Up		@@ -20,3 +20,4 @@ default:

		filters:
		tags: "@currencies&&@api"
		javascript: false