redis report #2289
Merged
redis report #2289
+101
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2025 08:44
ccostino
requested changes
Jan 23, 2025
There was a problem hiding this comment.
This is awesome to see and will be very useful, thanks @terrazoon!
I have the same note about the black/isort changes here in that we can't include them in the CI/CD pipeline like that (but we can work them in locally and just make sure folks do that!), and a quick question about the additional environment checks.
Co-authored-by: Carlo Costino <ccostino@users.noreply.github.com>
xlorepdarkhelm
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a Redis report to the platform admin area. Also, change the checks.yml so isort and black are run before file checks so style checks NEVER FAIL AGAIN when you push a PR.
Security Considerations
N/A