Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIGITAL-254: Update content exports for guide navigation. #140

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

omerida
Copy link
Contributor

@omerida omerida commented Jan 22, 2025

Jira ticket

DIGITAL-254

Purpose

Fixes the exported content for guide nodes where a node ID was used for a field reference instead of a UUID

Includes the following PRs that must be merged first

Deployment and testing

Local Setup

QA/Testing instructions

lando si - view the "Guides-required fields" and "Guides-all fields" nodes and confirm they render w/o fatal errors.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@omerida omerida requested a review from mattsqd January 22, 2025 03:50
Copy link
Collaborator

@mattsqd mattsqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a patch that should allow these link fields to not go away when content is exported.
I know you also had an issue where the guide field reference was also set to an integer instead of a uuid. Can you make sure that all the guides reference back to their proper guide navigation too please?

@omerida
Copy link
Contributor Author

omerida commented Jan 28, 2025

I've updated the content to match dev and now the net change is updating the patch for references. Latest content export didn't create numeric refs or remove any fields that shouldn't be.

@omerida omerida requested a review from mattsqd January 28, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants