Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix UI issue when a collection dataset with missing parent #277

Merged
merged 4 commits into from
Jan 24, 2024
Merged

fix UI issue when a collection dataset with missing parent #277

merged 4 commits into from
Jan 24, 2024

Conversation

Jin-Sun-tts
Copy link
Contributor

Pull Request

Related to GSA/data.gov#4553

About

  • added exception for parent dataset absent in collection
  • changed the UI to display differently to still allow user to search other datasets within same collection.

PR TASKS

  • The actual code changes.
  • Bumped version number in setup.py (also checked on PyPi).

@Jin-Sun-tts Jin-Sun-tts requested a review from a team January 24, 2024 16:44
btylerburton
btylerburton approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Jin-Sun-tts Jin-Sun-tts merged commit eabc515 into main Jan 24, 2024
2 checks passed
@Jin-Sun-tts Jin-Sun-tts deleted the fix-collection-with-missing-parent branch January 24, 2024 18:33
@Jin-Sun-tts Jin-Sun-tts mentioned this pull request Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btylerburton btylerburton btylerburton approved these changes

@FuhuXia FuhuXia FuhuXia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jin-Sun-tts @FuhuXia @btylerburton