Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use s3 delete-object to avoid Content-MD5 error #272

Merged
merged 3 commits into from
Sep 18, 2023
Merged

use s3 delete-object to avoid Content-MD5 error #272

merged 3 commits into from
Sep 18, 2023

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Sep 18, 2023 •
edited
Loading

Pull Request

Related to GSA/catalog.data.gov#1075 and GSA/data.gov#4442

About

Use delete_object instead of delete_objects

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?
  • Bumped version number in setup.py (also checked on PyPi).

nickumia-reisys
nickumia-reisys approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@nickumia-reisys nickumia-reisys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛷️

@FuhuXia FuhuXia mentioned this pull request Sep 18, 2023
Merged
@FuhuXia FuhuXia merged commit b3dc5ac into main Sep 18, 2023
2 checks passed
@FuhuXia FuhuXia deleted the s3-delete-objects branch September 18, 2023 20:33
@btylerburton
Copy link
Contributor

Nice fixes, Fuhu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickumia-reisys nickumia-reisys nickumia-reisys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FuhuXia @btylerburton @nickumia-reisys