Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 delete objects #271

Merged
merged 2 commits into from
Sep 18, 2023
Merged

S3 delete objects #271

merged 2 commits into from
Sep 18, 2023

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Sep 18, 2023

Pull Request

Related to GSA/catalog.data.gov#1075

About

S3 is from S3 = boto3.client(), not S3 = boto3.resource(). A better name would be s3_client.

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?
  • Bumped version number in setup.py (also checked on PyPi).

@FuhuXia FuhuXia requested a review from a team September 18, 2023 16:57
nickumia-reisys
nickumia-reisys approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@nickumia-reisys nickumia-reisys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎿

@robert-bryson robert-bryson merged commit b47fc54 into main Sep 18, 2023
2 checks passed
@robert-bryson robert-bryson deleted the s3-delete-objects branch September 18, 2023 17:08
@FuhuXia FuhuXia mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickumia-reisys nickumia-reisys nickumia-reisys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FuhuXia @nickumia-reisys @robert-bryson