Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-12616: Add axe accessibility scan #467

Merged
merged 12 commits into from
Mar 26, 2024
Merged

LG-12616: Add axe accessibility scan #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d9e4733
add accessibility tests
nprimak Mar 22, 2024
a1eeee4
fix eslint errors
nprimak Mar 25, 2024
244597c
Update spec/e2e/accessibility.test.js
nprimak Mar 25, 2024
c367f45
Update Makefile
nprimak Mar 25, 2024
df898a8
Update spec/e2e/accessibility.test.js
nprimak Mar 25, 2024
2b1650a
code review
nprimak Mar 25, 2024
5be7a61
add nvm and node install
nprimak Mar 25, 2024
ccfbd98
missing newline
nprimak Mar 25, 2024
185f0ca
more config.yml tweaks
nprimak Mar 25, 2024
cb6a9f3
update docker image
nprimak Mar 25, 2024
9795a1a
additional test failures that need to be ignored for now
nprimak Mar 25, 2024
adb2aa5
more eslint errors
nprimak Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,24 @@ jobs:
build:
docker:
# Specify the Ruby version you desire here
- image: cimg/ruby:3.1-node
- image: cimg/ruby:3.1-browsers

working_directory: ~/identity-dev-docs
steps:
- checkout

- run:
name: Switch Node.js version
command: |
wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.0/install.sh | bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, why 0.39.0 and not 0.39.7? Is there a better way to install ^0.39?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, this version is from 10/2021

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good call-out. This was copied from identity-site, where it was the latest version at the time of introduction. It was pinned to the specific version to avoid unexpected breakage from changing versions and for security, though in retrospect there's not much security assurances relying on git tags, since they can be deleted and recreated. SHA might be a better bet.

I'd think this could be bumped to the current latest version, assuming it works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just grabbed the same version/command that the identity-design-system is using for the sake of consistency -- https://github.com/18F/identity-design-system/blob/948b3326379f182fd4d5dbabcc10daca510763d7/.circleci/config.yml#L13-L20

export NVM_DIR="$HOME/.nvm"
. "$NVM_DIR/nvm.sh" --install --latest-npm
echo 'export NVM_DIR="$HOME/.nvm"' >> $BASH_ENV;
echo '[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"' >> $BASH_ENV;

- run:
name: Print Node.js version
command: node -v

- restore_cache:
key: v2-identity-dev-docs-{{ checksum "package-lock.json" }}-{{ checksum "Gemfile.lock" }}
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
lts/*
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ clean:

test: build
bundle exec rspec spec
node --test spec/e2e/

htmlproofer:
bundle exec scripts/htmlproofer
Expand Down
Loading
Loading