Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for rocket v0.5.0 #132

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Support for rocket v0.5.0 #132

merged 4 commits into from
Nov 21, 2023

Conversation

West14
Copy link
Contributor

@West14 West14 commented Nov 6, 2023

No description provided.

@West14
Copy link
Contributor Author

West14 commented Nov 8, 2023

cc: @ralpha

@ralpha
Copy link
Collaborator

ralpha commented Nov 9, 2023

Thanks for the MR :D I have seen the updates pop up in my inbox over the last few days.
I'll have a look in the (hopefully) near future. Don't know when, but should not be to long. (maybe this weekend if I find the time)
Also will have to look over the other recent issue and create fixes if needed so they are included in the next release. (help with that is welcome too)

@ralpha ralpha mentioned this pull request Nov 9, 2023
Closed
@svenstaro
Copy link

Well, Rocket 0.5 just got released!

@Nukesor
Copy link
Contributor

Nukesor commented Nov 18, 2023

Well, Rocket 0.5 just got released!

Should be an easy adjustment. There're practically no logic changes between rc.4 and the actual 0.5 release.

@jeertmans
Copy link

Well, Rocket 0.5 just got released!

Was actually just going to comment that! I can't wait for all my favorite Rocket plugins to work with 0.5 :D

@West14 West14 changed the title Support for rocket v0.5.0-rc.4 Support for rocket v0.5.0 Nov 18, 2023
ralpha
ralpha approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@ralpha ralpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing that I spotted, but will fix that when updating dependencies.

rocket-okapi/Cargo.toml
rocket_dyn_templates = { version = "=0.1.0-rc.4", optional = true }
rocket_db_pools = { version = "=0.1.0-rc.4", optional = true }
rocket_dyn_templates = { version = "=0.1.0", optional = true }
rocket_db_pools = { version = "=0.1.0", optional = true }

[dev-dependencies]
rocket_sync_db_pools = { version = "0.1.0-rc.3", features = ["diesel_sqlite_pool"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this one should be set to "0.1.0" too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, forgot about it :(

@ralpha ralpha merged commit df597f0 into GREsau:master Nov 21, 2023
1 check passed
@West14
Copy link
Contributor Author

West14 commented Nov 21, 2023

Thanks!

@ralpha
Copy link
Collaborator

ralpha commented Nov 21, 2023

Haha, did not expect v0.5 to come out. 😅 Been a a while since we have been on a rc 😄

@ralpha
Copy link
Collaborator

ralpha commented Nov 21, 2023

Thanks for the MR, will do some more updates, maintenance, tests and other changes before I publish to crates.io
If anyone finds any bugs or issues, let me know so I can patch it before I publish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralpha ralpha ralpha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@West14 @ralpha @svenstaro @Nukesor @jeertmans