Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make it compatible with Python3, remove -Werror #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make it compatible with Python3, remove -Werror #39

wants to merge 2 commits into from

Conversation

matthiasdiener
Copy link

@matthiasdiener matthiasdiener commented Jun 16, 2020 •
edited
Loading

Fixes #34.

@matthiasdiener matthiasdiener mentioned this pull request Jun 16, 2020
Open
@baryluk
Copy link

baryluk commented Jun 16, 2020 •
edited
Loading

Why you need to use 2to3 at runtime and not change all problematic places once and commit this to repo?

@matthiasdiener
Copy link
Author

matthiasdiener commented Jun 16, 2020 •
edited
Loading

Why you need to use 2to3 at runtime and not change all problematic places once and commit this to repo?

Because CXL_init.py (the only file handled by 2to3) is not actually contained within this repo (it is a symlink to ../Common/Src/Scons), but is located in a read-only, archived repo (https://github.com/GPUOpen-Archive/common-src-SCons), and I therefore can't open Pull Requests that modify this file anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure in scons
2 participants
@matthiasdiener @baryluk