Added a simple compilation test and linux CI (and fix linux build) #446
+99
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compilation test is required because the smaple is windows-specific. Linux CI is needed because pull requests must stop breaking linux builds.
adam-sawicki-a
requested changes
Sep 2, 2024
| @@ -16675,7 +16675,7 @@ VMA_CALL_PRE VkResult VMA_CALL_POST vmaGetMemoryWin32Handle(VmaAllocator VMA_NOT | |||
| VMA_DEBUG_GLOBAL_MUTEX_LOCK; | |||
| return allocation->GetWin32Handle(allocator, hTargetProcess, pHandle); | |||
| } | |||
| #endif // VMA_EXTERNAL_MEMORY_WIN32 | |||
| #endif // VMA_EXTERNAL_MEMORY_WIN32 | |||
There was a problem hiding this comment.
It seems that you change many lines that are unrelated to your change due to using some automated formatting tools. Changes like this make it difficult to analyze the history of a file later (like "blame" function).
There was a problem hiding this comment.
Would it be possible to reuse VulkanSample app for testing compilation on Linux instead of creating a new project? VulkanSample.cpp and VmaUsage.* files already have appropriate #ifdef-s and even some Clang-specific #pragma directives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial compilation test is required because the sample is windows-specific. Linux CI is needed because pull requests must stop breaking linux builds. The tiny
m_Handle(VMA_NULL)->m_Handle()fix is needed to fix linux CI.As promised @adam-sawicki-a . Same day delivery because my CI is still broken =)
(I will stop using master for my builds soon, I promise)