prepare for Qt 6.8 deprecations #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, the exif writer now prefers to establish a timestamp from GPS_IFD_TAG_DATESTAMP/GPS_IFD_TAG_TIMESTAMP if they exist, as the exif reader does.
which appeared with 6.7.0
|
There is also a fix for a QDomDocument deprecation in the gui upgrade check. |
qt version depependent defined constants.
I beleive the original intent of the writer is to create the gps tags from a waypoint.
|
The warnings (and counts) being fixed are: |
1. allow builds to succeed without webengine by default. This is needed by CI until aqt catches up. 2. macos minos change for 6.8 3. add macos 6.8.0 to CI, remove macos-12 build.
|
This PR automatically disables the GUI map preview feature if QtWebEngine and/or QtWebChannel are not found. This allows CI to work with aqt 3.1.18. miurahr/aqtinstall#803, albeit without QtWebEngine. 6.8.0 builds are added to CI for windows and macos-15 (beta). The macos-12 build is removed, the runner is being deprecated. actions/runner-images#10721. |
|
Thanx for handling all these fiddly bits.
…On Tue, Oct 8, 2024 at 7:46 AM tsteven4 ***@***.***> wrote:
Merged #1346 <#1346> into master.
—
Reply to this email directly, view it on GitHub
<#1346 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCSD3YLLC5HTVNKLGY7B73Z2PH3HAVCNFSM6AAAAABPA72XLCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGU2TMMRTHE3DKMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids deprecation warning with CMAKE_BUILD_TYPE=Release. QDateTime is transitioning from Qt::TimeSpec to QTimeZone. Lightweight times zones for LocalTime and UTC were added in 6.5.0. Warnings are appearing in pre-release versions of 6.8.0.
Also, the exif writer now prefers to establish a timestamp fromGPS_IFD_TAG_DATESTAMP/GPS_IFD_TAG_TIMESTAMP if possible, as the
exif reader does.