Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate faster #2413

Merged
merged 10 commits into from
Sep 29, 2024
Merged

Duplicate faster #2413

merged 10 commits into from
Sep 29, 2024

Conversation

z5241248
Copy link
Contributor

Copying project files directly, rather than copying them in an import-export fashion, can make copying projects many times faster

…-export fashion, can make copying projects many times faster
@z5241248 z5241248 mentioned this pull request Sep 23, 2024
…-export fashion, can make copying projects many times faster
@grossmj grossmj changed the base branch from master to 2.2 September 25, 2024 12:39
@grossmj
Copy link
Member

grossmj commented Sep 26, 2024

I have made some minor changes. I will do some more tests tomorrow and I expect to merge your code after that. Thanks 👍

@z5241248
Copy link
Contributor Author

I expect to merge your code

In addition to the code, I noticed you have corrected a few grammatical errors.

My native language is not English, so thank you for correcting the code. That's great.

Expect good results.

@z5241248
Copy link
Contributor Author

I have made some minor changes. I will do some more tests tomorrow and I expect to merge your code after that. Thanks 👍

What are the test results now?

@grossmj grossmj merged commit a1922ef into GNS3:2.2 Sep 29, 2024
6 checks passed
@grossmj
Copy link
Member

grossmj commented Sep 29, 2024

Merged! thanks again for this contribution! 👍

@z5241248
Copy link
Contributor Author

Merged! thanks again for this contribution! 👍

Hello, I asked you a question on the GNS3 web message, could you reply to me when you have time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants