Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] an issue where the shell option in dialog failed to drop you back to bash. #2314

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

Xatrekak
Copy link
Contributor

@Xatrekak Xatrekak commented Nov 5, 2023

Fixed an issue where the shell option in dialog failed to drop you back to bash.

This commit will cause this version of the welcome.py dialog to differ from the one included with the GNS3 VM found here

While very usable there are numerous bugs the with welcome.py dialog when installed via remote-install.sh.

If having this version of welcome.py differ from the VM version is not a concern I can go through and easily clean up most of these issues.

Fixed an issue where the shell option in dialog failed to drop you back to bash.
@grossmj
Copy link
Member

grossmj commented Nov 6, 2023

If having this version of welcome.py differ from the VM version is not a concern I can go through and easily clean up most of these issues.

This isn't a concern. Thanks for your help! 👍

@grossmj grossmj merged commit 531499b into GNS3:master Nov 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants