Packaging migration #2270
Merged
Packaging migration #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grossmj
commented
Aug 10, 2023
Comment on lines
69
to
77
| for busybox_exec in ("busybox-static", "busybox.static", "busybox"): | ||
| busybox_path = shutil.which(busybox_exec) | ||
| if busybox_path: | ||
| log.info(f"Installing busybox from '{busybox_path}'") | ||
| try: | ||
| shutil.copy2(busybox_path, dst_busybox, follow_symlinks=True) | ||
| return | ||
| except OSError as e: | ||
| raise DockerError(f"Could not install busybox: {e}") |
There was a problem hiding this comment.
@b-ehlers
I have migrated the code found in setup.py however why did you need to call the ldd command?
https://github.com/GNS3/gns3-server/blob/3.0/setup.py#L34L39
Thanks.
There was a problem hiding this comment.
The ldd command returns a non-zero return code, if its argument is not dynamically linked. So I used it as a quick way to detect if a program is statically linked. For docker a statically linked busybox is needed, a dynamically linked busybox program won't help us.
There was a problem hiding this comment.
Oh yes I remember now. Thanks for reminding me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.