Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reactos version 21 #921

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix reactos version 21 #921

merged 1 commit into from
Sep 26, 2024

Conversation

saviodsouza
Copy link
Contributor

Before submitting a pull request, please check the following.


When updating an existing appliance:

  • The new version is on top.
  • The filenames in the "images" section are unique, to avoid appliances / version overwriting each other.
  • If you forked the repo, running check.py doesn't drop any errors for the updated file.

When creating a new appliance:

  • It's tested locally, i.e.
    • You dragged an instance into a project on your box, got it installed (if necessary), and did some basic network checks (ping, UI reachable, etc.).
    • GNS3 VM can run it without any tweaks.
    • The device is in the right category: router, switch, guest (hosts), firewall
    • You filled in as much info as possible (checks the schemas and other appliance files for some guidance).
  • When adding a container: it builds on Docker Hub and can be pulled.
  • The filenames in the "images" section are unique (to avoid appliances and/or versions overwriting each other).
  • If you forked the repo, running check.py doesn't drop any errors for the new file.
  • Optional: a symbol has been created for the new appliance.

@grossmj grossmj merged commit 7702e46 into GNS3:master Sep 26, 2024
3 checks passed
@grossmj grossmj linked an issue Sep 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReactOS version is incorrect
2 participants