Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 32-bit SMBIOS in all Juniper appliances #905

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Use 32-bit SMBIOS in all Juniper appliances #905

merged 1 commit into from
Jul 31, 2024

Conversation

grossmj
Copy link
Member

@grossmj grossmj commented Jul 23, 2024

No description provided.

@grossmj grossmj linked an issue Jul 23, 2024 that may be closed by this pull request
Juniper devices failing to boot GNS3/gns3-server#2405
Closed
@ghost
Copy link

ghost commented Jul 23, 2024 •
edited by ghost
Loading

Are you sure, it is good to remove the -smp xxx option? As far as I know most juniper appliances need more than one core.

Sorry, forget it. You moved the -smp values to the "cpus" parameter, all good.

@grossmj
Copy link
Member Author

grossmj commented Jul 23, 2024 •
edited
Loading

Are you sure, it is good to remove the -smp xxx option? As far as I know most juniper appliances need more than one core.

I have added the "cpus" setting instead, it uses -smp when starting a Qemu VM: https://github.com/GNS3/gns3-server/blob/2.2/gns3server/compute/qemu/qemu_vm.py#L2394

@grossmj grossmj merged commit da305f8 into master Jul 31, 2024
3 checks passed
@grossmj grossmj deleted the use-32bit-smbios-juniper-devices branch July 31, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Juniper devices failing to boot
1 participant
@grossmj