Merge pull request #262 from flaviojs/fix-null-check-cpu_group_find_h…

…ighest_id Fix null check in cpu_group_find_highest_id.
GNS3 · Oct 6, 2024 · f351cef · f351cef
2 parents 119d171 + 8460a78
commit f351cef
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/stable/cpu.c b/stable/cpu.c
@@ -50,7 +50,7 @@ int cpu_group_find_highest_id(cpu_group_t *group,u_int *highest_id)
    cpu_gen_t *cpu;
    u_int max_id = 0;
 
-   if (!group || group->cpu_list)
+   if (!group || !group->cpu_list)
       return(-1);
 
    for(cpu=group->cpu_list;cpu;cpu=cpu->next)

diff --git a/unstable/cpu.c b/unstable/cpu.c
@@ -51,7 +51,7 @@ int cpu_group_find_highest_id(cpu_group_t *group,u_int *highest_id)
    cpu_gen_t *cpu;
    u_int max_id = 0;
 
-   if (!group || group->cpu_list)
+   if (!group || !group->cpu_list)
       return(-1);
 
    for(cpu=group->cpu_list;cpu;cpu=cpu->next)