Merge pull request #149 from flaviojs/fix-descriptor-leaks-mips64_loa…

…d_raw_image Fix descriptor leaks in mips64_load_raw_image
GNS3 · Mar 9, 2024 · 00a91df · 00a91df
2 parents 370c1f7 + 71af69a
commit 00a91df
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/stable/mips64.c b/stable/mips64.c
@@ -865,6 +865,7 @@ int mips64_load_raw_image(cpu_mips_t *cpu,char *filename,m_uint64_t vaddr)
 
    if (fstat(fileno(bfd),&file_info) == -1) {
       perror("stat");
+      fclose(bfd);
       return(-1);
    }
 
@@ -880,6 +881,7 @@ int mips64_load_raw_image(cpu_mips_t *cpu,char *filename,m_uint64_t vaddr)
       if (!haddr) {
          fprintf(stderr,"load_raw_image: invalid load address 0x%llx\n",
                  vaddr);
+         fclose(bfd);
          return(-1);
       }
 

diff --git a/unstable/mips64.c b/unstable/mips64.c
@@ -948,6 +948,7 @@ int mips64_load_raw_image(cpu_mips_t *cpu,char *filename,m_uint64_t vaddr)
 
    if (fstat(fileno(bfd),&file_info) == -1) {
       perror("stat");
+      fclose(bfd);
       return(-1);
    }
 
@@ -963,6 +964,7 @@ int mips64_load_raw_image(cpu_mips_t *cpu,char *filename,m_uint64_t vaddr)
       if (!haddr) {
          fprintf(stderr,"load_raw_image: invalid load address 0x%llx\n",
                  vaddr);
+         fclose(bfd);
          return(-1);
       }