mixer-stream: handle portless streams during profile transitions#1
Closed
PhilBrk8 wants to merge 1 commit intoGNOME:masterfrom
Closed
mixer-stream: handle portless streams during profile transitions#1PhilBrk8 wants to merge 1 commit intoGNOME:masterfrom
PhilBrk8 wants to merge 1 commit intoGNOME:masterfrom
Conversation
|
Thank you for contributing to libgnome-volume-control! libgnome-volume-control uses GitLab for code review. As such we have forwarded https://gitlab.gnome.org/GNOME/libgnome-volume-control/-/issues/38 GNOME's GitLab instance also supports GitHub as one of the possible https://gitlab.gnome.org/users/sign_in If you are interested in sticking around within the GNOME community we https://www.gnome.org/get-involved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gvc_mixer_stream_get_port()Background
When WirePlumber switches Bluetooth profiles (A2DP ↔ HFP),
the stream can be in a transient state where
stream->priv->portsis NULL.GVC currently asserts on this, which crashes gsd-media-keys and gnome-shell.
Fix
Make
gvc_mixer_stream_get_port()tolerant of NULL ports andreturn NULL with a debug log instead of aborting.
Cross‑reference
Companion mitigation in WirePlumber PR:
PipeWire/wireplumber#16
This defers profile switching until EnumRoute data is available, reducing the likelihood of the portless transient state.
Test plan
libgnome-volume-controlis intended as a subproject.