Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept cache as a parameter to constructor #139

Open
cmdcolin opened this issue Mar 23, 2023 · 0 comments
Open

Accept cache as a parameter to constructor #139

cmdcolin opened this issue Mar 23, 2023 · 0 comments

Comments

@cmdcolin
Copy link
Contributor

cmdcolin commented Mar 23, 2023

Our packages have stayed on old versions of quick-lru because updating to the latest causes bundling issues. jbrowse-web bundles at least three versions of quick-lru: v2, v4, and v6 (quick-lru v6 is vendored in @jbrowse/core/util/QuickLRU)

Two possible solutions are

accept quick-lru as parameter to constructor. this also gives maximum cache control to the application, which may have specialized needs

use quick-lru as a peerDependency, and still initialize it import it this library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant