Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for duplicates in proc with traveling salesman #275

Merged
merged 10 commits into from
Aug 27, 2024
Merged

fix: check for duplicates in proc with traveling salesman #275

merged 10 commits into from
Aug 27, 2024

Conversation

merydian
Copy link
Collaborator

@merydian merydian commented Aug 9, 2024

This checks whether the input list points has any duplicates and if so raises a new DuplicateError.

@merydian merydian linked an issue Aug 9, 2024 that may be closed by this pull request
Traveling Salesman fails with duplicate points #274
Closed
@koebi koebi added the easy fix Issues that are rather quick to be resolved label Aug 16, 2024
@koebi
Copy link
Collaborator

koebi commented Aug 23, 2024

Is this something we should also do for non-proc, i.e. the GUI?

koebi
koebi requested changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@koebi koebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried it yet, but looks good so far :)

ORStools/proc/directions_points_layer_proc.py Outdated Show resolved Hide resolved
koebi
koebi requested changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@koebi koebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that translation is missing. I will add that tomorrow.

ORStools/gui/ORStoolsDialog.py Outdated Show resolved Hide resolved
ORStools/gui/ORStoolsDialog.py Outdated Show resolved Hide resolved
ORStools/proc/directions_points_layer_proc.py Outdated Show resolved Hide resolved
@koebi koebi merged commit 0131012 into main Aug 27, 2024
5 checks passed
@koebi koebi deleted the 274-traveling-salesman-fails-with-duplicate-points branch August 27, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koebi koebi koebi approved these changes

Assignees
No one assigned
Labels
easy fix Issues that are rather quick to be resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Traveling Salesman fails with duplicate points
2 participants
@merydian @koebi